Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

guess_signed #1128

Merged
merged 19 commits into from
Jan 30, 2024
Merged

guess_signed #1128

merged 19 commits into from
Jan 30, 2024

Conversation

rpm4
Copy link
Contributor

@rpm4 rpm4 commented Jun 21, 2023 •
edited by ddkohler
Loading

Changes

Checklist

  • added tests, if applicable
  • updated documentation, if applicable
  • updated CHANGELOG.md
  • tests pass

@ksunden ksunden closed this Jun 21, 2023
@ksunden ksunden reopened this Jun 21, 2023
ddkohler
ddkohler approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@ddkohler ddkohler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please round out the docstring, then we are good to go.

WrightTools/kit/_array.py Outdated Show resolved Hide resolved
ddkohler
ddkohler reviewed Jun 21, 2023
View reviewed changes
WrightTools/kit/_array.py Outdated Show resolved Hide resolved
ddkohler
ddkohler reviewed Jun 21, 2023
View reviewed changes
tests/kit/signed.py Outdated Show resolved Hide resolved
ddkohler
ddkohler reviewed Jun 21, 2023
View reviewed changes
tests/kit/signed.py Outdated Show resolved Hide resolved
ddkohler
ddkohler reviewed Jan 26, 2024
View reviewed changes
WrightTools/kit/_array.py Outdated Show resolved Hide resolved
@ddkohler ddkohler changed the title Update _array.py guess_signed Jan 26, 2024
@ddkohler ddkohler merged commit 1a2fbb9 into wright-group:master Jan 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddkohler ddkohler ddkohler approved these changes

@untzag untzag Awaiting requested review from untzag untzag is a code owner

@ksunden ksunden Awaiting requested review from ksunden ksunden is a code owner

@darienmorrow darienmorrow Awaiting requested review from darienmorrow darienmorrow is a code owner

@kameyer226 kameyer226 Awaiting requested review from kameyer226 kameyer226 is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kit function for guessing array plotting params
3 participants
@rpm4 @ddkohler @ksunden