refactor quicknd #1170
Merged
refactor quicknd #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
rely on base library for cmap logic
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
use existing code for label creation
ddkohler
requested review from
untzag,
ksunden,
darienmorrow and
kameyer226
as code owners
fix save directory issue
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
not relevant to this PR
kameyer226
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first part of a broader effort to revamp the artists module. These changes focus on reducing the redundant code within quick1D and quick2D. Before this PR, both functions had almost independent code, despite performing very similar operations. Now they are built with the same core utility (ChopHandler). ChopHandler also makes it easy to create new quick artists, either by users or potentially to be included in the artists package.
Changes
ChopHandler class: allow to be used as an iterator or as a for loopto be implemented laterimplementcontext will be a future changecontextkwarg for simple style changes (and write a standard quick style file)Checklist