WIP/MAINT: Downscale convolve #863
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes dependency scikit-image
Alternative implementation to #862
ksunden
requested review from
darienmorrow,
ddkohler and
untzag
as code owners
ksunden
commented
Jan 16, 2019
| @@ -897,10 +897,9 @@ def create_variable( | |||
| def downscale(self, tup, name=None, parent=None) -> "Data": | |||
| """Down sample the data array using local averaging. | |||
|
|
|||
| See `skimage.transform.downscale_local_mean`__ for more info. | |||
| See `scipy.signal.decimate`__ for more info. | |||
There was a problem hiding this comment.
Left over from first rewrite, if we move forward with this one, needs updating.
Also applies to internal function name
untzag
pushed a commit
that referenced
this pull request
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #862