Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Reserved character Issue in Certs #12134

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

BLasan
Copy link
Contributor

@BLasan BLasan commented Aug 18, 2023

chamilaadhi
chamilaadhi previously approved these changes Aug 18, 2023
RakhithaRR
RakhithaRR previously approved these changes Aug 22, 2023
@RakhithaRR
Copy link
Contributor

Verify the test failures before merging

@BLasan
Copy link
Contributor Author

BLasan commented Aug 22, 2023

Verify the test failures before merging

Tests are continuously failing from the previous PRs

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 34.72%. Comparing base (8562c1f) to head (cbe028b).
Report is 24 commits behind head on master.

❗ Current head cbe028b differs from pull request most recent head 88673c6. Consider uploading reports for the commit 88673c6 to get more accurate results

Files Patch % Lines
.../carbon/apimgt/impl/utils/CertificateMgtUtils.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12134      +/-   ##
============================================
+ Coverage     26.10%   34.72%   +8.62%     
+ Complexity     9876     2344    -7532     
============================================
  Files          1860     1840      -20     
  Lines        137868   136334    -1534     
  Branches      20012    19724     -288     
============================================
+ Hits          35990    47346   +11356     
+ Misses        96663    82712   -13951     
- Partials       5215     6276    +1061     
Flag Coverage Δ
integration_tests 27.07% <0.00%> (+0.96%) ⬆️
unit_tests 20.47% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@BLasan BLasan force-pushed the fix-mtls-cert-character-issue branch from 88673c6 to d1c972f Compare July 29, 2024 01:43
@BLasan BLasan merged commit d0a2629 into wso2:master Aug 1, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publishing api with certificates which contain "&" symbol generates an error
4 participants