[Feature] Add Burst control capability for Applications #12162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chamilaadhi
reviewed
Oct 31, 2023
| @@ -627,6 +638,15 @@ private boolean doThrottle(MessageContext messageContext) { | |||
| initThrottleForSubscriptionLevelSpikeArrest(messageContext, authenticationContext); | |||
| context.stop(); | |||
| } | |||
|
|
|||
| if(authenticationContext != null && authenticationContext.getApplicationSpikesArrestLimit() > 0) { | |||
There was a problem hiding this comment.
fixed in b56bf30
chamilaadhi
reviewed
Oct 31, 2023
| try { | ||
| parsedPolicy = AXIOMUtil.stringToOM(policy.toString()); | ||
| } catch (XMLStreamException e) { | ||
| log.error("Error occurred while creating policy file for Hard Throttling.", e); |
There was a problem hiding this comment.
add a reason why this exception is ignored (without throwing an exception and stopping the flow)
There was a problem hiding this comment.
added in b56bf30
chamilaadhi
reviewed
Oct 31, 2023
| String applicationLevelThrottleKey = authenticationContext.getApplicationId()+":"+authenticationContext.getUsername(); | ||
| int maxRequestCount = authenticationContext.getApplicationSpikesArrestLimit(); | ||
| int applicationSpikeArrestWindowUnitTime = 0; | ||
| if(maxRequestCount != 0) { |
There was a problem hiding this comment.
fixed in b56bf30
chamilaadhi
reviewed
Oct 31, 2023
| private void initThrottleForApplicationLevelSpikeArrest(MessageContext synCtx, | ||
| AuthenticationContext authenticationContext) { | ||
| policyKeyApplication = authenticationContext.getApplicationTier(); | ||
| String applicationLevelThrottleKey = authenticationContext.getApplicationId()+":"+authenticationContext.getUsername(); |
There was a problem hiding this comment.
fixed in b56bf30
chamilaadhi
reviewed
Oct 31, 2023
| } | ||
|
|
||
| private void setRateLimitDetails(ApplicationPolicy policy, ResultSet resultSet) throws SQLException { | ||
| if(resultSet.getInt(ThrottlePolicyConstants.COLUMN_RATE_LIMIT_COUNT) > 0) { |
There was a problem hiding this comment.
fixed in b56bf30
Arshardh
reviewed
Nov 6, 2023
| @@ -180,6 +180,25 @@ public void setConsumerKey(String consumerKey) { | |||
| this.consumerKey = consumerKey; | |||
| } | |||
|
|
|||
| private int applicationSpikesArrestLimit; | |||
There was a problem hiding this comment.
Shall we add the variables along with the other variables on the top?
There was a problem hiding this comment.
Refactored in 547e395
shilmyhasan
commented
Nov 27, 2023
| import org.wso2.carbon.apimgt.internal.service.dto.SubscriptionPolicyListDTO; | ||
| import org.wso2.carbon.apimgt.internal.service.dto.ThrottleLimitDTO; | ||
| import org.wso2.carbon.apimgt.internal.service.dto.URLMappingDTO; | ||
| import org.wso2.carbon.apimgt.internal.service.dto.*; |
There was a problem hiding this comment.
change the import into individual
tharindu1st
previously approved these changes
Dec 14, 2023
chamilaadhi
previously approved these changes
Dec 14, 2023
|
|
shilmyhasan
force-pushed
the
master-appburstcontrol
branch
from
4f025c3
to
407a5bc
Compare
shilmyhasan
dismissed stale reviews from tharindu1st and chamilaadhi
via
588ce33
chamilaadhi
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds the capability to support burst control for Application policies similar to what the product already has for Subscription policies.