Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation for endpoint authentication properties in authenticator create flows #828

Merged
merged 7 commits into from
Feb 4, 2025
Merged

Add validation for endpoint authentication properties in authenticator create flows #828

merged 7 commits into from
Feb 4, 2025
+61 −13

Conversation

ashanthamara
Copy link
Contributor

@ashanthamara ashanthamara commented Feb 4, 2025 •
edited
Loading

Purpose

This will add validations on the endpoint authentication properties on authenticator and federated-authenticator create flows, as authentication properties is a required attribute

Depends on : wso2/carbon-identity-framework#6424

Related Issue

malithie
malithie previously approved these changes Feb 4, 2025
View reviewed changes
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13133794228

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13133794228
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13136587496

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13136587496
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Feb 4, 2025
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13136587496

@ashanthamara ashanthamara merged commit 2fb8f31 into wso2:master Feb 4, 2025
4 checks passed
@ashanthamara ashanthamara mentioned this pull request Feb 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malithie malithie malithie left review comments

@Thisara-Welmilla Thisara-Welmilla Thisara-Welmilla approved these changes

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashanthamara @jenkins-is-staging @malithie @Thisara-Welmilla