Add pre auth and tenant switch improvement for central deployment related authentication #7291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7291 +/- ##
=======================================
Coverage 41.85% 41.85%
=======================================
Files 42 42
Lines 939 939
Branches 217 230 +13
=======================================
Hits 393 393
+ Misses 546 502 -44
- Partials 0 44 +44
Flags with carried forward coverage won't be shown. Click here to find out more. |
bhagyasakalanka
force-pushed
the
central-deployment-imprs
branch
6 times, most recently
from
52544f6 to
066a888
Compare
bhagyasakalanka
changed the title
bhagyasakalanka
force-pushed
the
central-deployment-imprs
branch
2 times, most recently
from
c2201d6 to
fbb1a84
Compare
bhagyasakalanka
force-pushed
the
central-deployment-imprs
branch
from
fbb1a84 to
19e90ca
Compare
bhagyasakalanka
force-pushed
the
central-deployment-imprs
branch
from
9a347f0 to
21a41d6
Compare
| "@wso2is/myaccount": minor | ||
| "@wso2is/console": minor | ||
| "@wso2is/core": minor | ||
| "@wso2is/i18n": minor |
There was a problem hiding this comment.
add admin.base.v1 too
| @@ -1,5 +1,5 @@ | |||
| /** | |||
| * Copyright (c) 2021, WSO2 LLC. (https://www.wso2.com). All Rights Reserved. | |||
| * Copyright (c) 2021, WSO2 LLC. (https://www.wso2.com). | |||
There was a problem hiding this comment.
Suggested change
| * Copyright (c) 2021, WSO2 LLC. (https://www.wso2.com). | |
| * Copyright (c) 2021-2025, WSO2 LLC. (https://www.wso2.com). |
| placeholder = { t("tenants:deploymentUtits.placeholder") } | ||
| required={ true } | ||
| options={ deploymentUnitOptions } | ||
| readOnly={ true } |
There was a problem hiding this comment.
if this is readonly, end users may not be able to select the region, might they?
There was a problem hiding this comment.
It worked locally with above configurations
| if (deploymentUnitJson === undefined) { | ||
| setIsValidDeploymentUnit(false); | ||
| } else { | ||
| setSelectedDeploymentUnit(deploymentUnitJson??JSON.parse(deploymentUnitJson)); |
There was a problem hiding this comment.
Suggested change
| setSelectedDeploymentUnit(deploymentUnitJson??JSON.parse(deploymentUnitJson)); | |
| setSelectedDeploymentUnit(deploymentUnitJson ??JSON.parse(deploymentUnitJson)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Checklist
Security checks