Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attribute sorting in user profiles #7636

Merged
merged 3 commits into from
Feb 16, 2025

Conversation

PasinduYeshan
Copy link
Contributor

This PR fixes an issue where attributes without a defined displayOrder were appearing at the beginning of the user profile. With this update, any attribute missing a displayOrder will now be shown at the end of the profile.

Eg: sharedType doesn't have a displayOrder.

image

With this change if schema doesn't have order Id it will be shown at the end of the user profile
image

Copy link

codecov bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.85%. Comparing base (97b2bd8) to head (64b957d).
Report is 20 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7636   +/-   ##
=======================================
  Coverage   41.85%   41.85%           
=======================================
  Files          42       42           
  Lines         939      939           
  Branches      238      238           
=======================================
  Hits          393      393           
  Misses        546      546           
Flag Coverage Δ
@wso2is/core 41.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@PasinduYeshan PasinduYeshan merged commit fb708fc into wso2:master Feb 16, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants