Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove root admin validations #7648

Merged

Conversation

inthirakumaaran
Copy link
Contributor

@inthirakumaaran inthirakumaaran commented Feb 17, 2025

Related to wso2/product-is#22411


Changes

Add tenant form

  • Remove root admin username and password validation
  • Validate admin email
Screenshot 2025-02-18 at 10 29 54

Edit tenant form

  • Remove root admin username validation(Password validation will be preserved in align with API)
  • Validate admin email
Screenshot 2025-02-18 at 10 31 24

@inthirakumaaran inthirakumaaran force-pushed the remove_root_admin_validation branch from 2c1f477 to 3b92726 Compare February 17, 2025 10:53
@inthirakumaaran inthirakumaaran force-pushed the remove_root_admin_validation branch from 3b92726 to 47c768b Compare February 17, 2025 10:55
brionmario
brionmario previously approved these changes Feb 17, 2025
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.85%. Comparing base (3e098ee) to head (10dc208).
Report is 111 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7648   +/-   ##
=======================================
  Coverage   41.85%   41.85%           
=======================================
  Files          42       42           
  Lines         939      939           
  Branches      238      217   -21     
=======================================
  Hits          393      393           
- Misses        502      546   +44     
+ Partials       44        0   -44     
Flag Coverage Δ
@wso2is/core 41.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

@pavinduLakshan
Copy link
Contributor

Let's fix the lint issues.

@inthirakumaaran inthirakumaaran changed the title Remove root admin validation Remove root admin validations Feb 18, 2025
@inthirakumaaran inthirakumaaran merged commit 7c6eae8 into wso2:master Feb 18, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants