Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug-fix] Fix issues related to read only LDAP user store #7656

Merged
merged 9 commits into from
Feb 18, 2025

Conversation

JayaShakthi97
Copy link
Contributor

@JayaShakthi97 JayaShakthi97 commented Feb 17, 2025

Purpose

Fix following issues mentioned in comments;

Related Issues

Related PRs

  • N/A

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.85%. Comparing base (5e22de7) to head (0905b63).
Report is 70 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7656   +/-   ##
=======================================
  Coverage   41.85%   41.85%           
=======================================
  Files          42       42           
  Lines         939      939           
  Branches      217      231   +14     
=======================================
  Hits          393      393           
+ Misses        546      502   -44     
- Partials        0       44   +44     
Flag Coverage Δ
@wso2is/core 41.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

DonOmalVindula
DonOmalVindula previously approved these changes Feb 18, 2025
@JayaShakthi97
Copy link
Contributor Author

The PR builder ran and verified it in the fork.

image

@JayaShakthi97 JayaShakthi97 marked this pull request as ready for review February 18, 2025 05:49
@JayaShakthi97 JayaShakthi97 merged commit d9be617 into wso2:master Feb 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants