Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react): temp fix for composition issues due to MuiWrapperProps #289

Merged
merged 3 commits into from
Oct 14, 2024
Merged

fix(react): temp fix for composition issues due to MuiWrapperProps #289

merged 3 commits into from
Oct 14, 2024

Conversation

brionmario
Copy link
Member

@brionmario brionmario commented Oct 14, 2024 •
edited
Loading

Purpose

Temporarily remove muiName and displayName from composed components.

Related Issues

Related PRs

  • N/A

Checklist

  • Figma Board Updated. (Mandatory for Icon and Component PRs. If you don't have access, please ask the core team to update it.)
  • UX/UI review done on the final implementation.
  • Story provided. (Add screenshots)
  • Manual test round performed and verified.
  • Unit tests provided. (Add links if there are any)
  • Documentation provided. (Add links if there are any)

Security checks

@brionmario brionmario changed the title fix(react): fix Card composition issues fix(react): temp fix for composition issues due to MuiWrapperProps Oct 14, 2024
pavinduLakshan
pavinduLakshan previously approved these changes Oct 14, 2024
View reviewed changes
@pavinduLakshan pavinduLakshan dismissed their stale review October 14, 2024 13:13

pr builder failure

@brionmario brionmario force-pushed the migrate-default-props branch from f899741 to 1d85942 Compare October 14, 2024 13:14
@brionmario brionmario merged commit 9063178 into wso2:main Oct 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavinduLakshan pavinduLakshan pavinduLakshan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brionmario @pavinduLakshan