feat(react): add AccountOverview component
#58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brionmario
reviewed
Mar 7, 2023
packages/react/src/components/AccountOverview/AccountOverview.stories.mdx
Outdated
Show resolved
Hide resolved
brionmario
reviewed
Mar 7, 2023
| @@ -60,6 +60,15 @@ | |||
| z-index: 1; | |||
| position: absolute; | |||
| width: 100%; | |||
| bottom: calc(42px + 1em); | |||
| // TODO: Review this. | |||
There was a problem hiding this comment.
Whats the reason for the absolute positioning?
There was a problem hiding this comment.
Absolute positioning was required for the navigation buttons in the Mobile screen.
There was a problem hiding this comment.
The design looks like a UI issue to me. Shall we check what we can do to improve?
There was a problem hiding this comment.
A discussion is being done on a better design for the buttons. A fix is added until the decision is finalized - ec27f4f
thivi
reviewed
Mar 7, 2023
packages/react/src/components/AccountOverview/AccountOverview.stories.mdx
Show resolved
Hide resolved
packages/react/src/components/AccountOverview/AccountOverview.stories.mdx
Outdated
Show resolved
Hide resolved
Comment on lines
+20
to
+28
| padding: 0.8rem 1rem; | ||
|
|
||
| .oxygen-card-header { | ||
| padding: 1rem 0; | ||
| padding-bottom: 1.5rem; | ||
| } | ||
|
|
||
| .oxygen-account-completion-steps-box { | ||
| padding: 0.5rem; |
There was a problem hiding this comment.
Can't we use the default spacing values?
There was a problem hiding this comment.
Currently we do not have any default spacing values defined in the default theme.
thivi
previously approved these changes
Mar 8, 2023
brionmario
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
AccountOverviewcardDesktop
Mobile
Related Issues
Related PRs
Checklist
Security checks