Add integrations tests to check malformed API contexts #13234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build is failed |
BLasan
previously approved these changes
Jul 11, 2023
|
dulithsenanayake
force-pushed
the
context-validation
branch
from
997670f
to
57522af
Compare
npamudika
reviewed
Jan 30, 2024
| HttpResponse response = null; | ||
|
|
||
| ArrayList<String> policies = new ArrayList<String>(); | ||
| policies.add("Unlimited"); |
There was a problem hiding this comment.
Shall we use APIMIntegrationConstants.API_TIER.UNLIMITED?
There was a problem hiding this comment.
Fixed from a31b2d2
npamudika
reviewed
Jan 30, 2024
| JSONObject additionalPropertiesObj = new JSONObject(); | ||
| additionalPropertiesObj.put("name", "GraphQLAPIWithInvalidContext"); | ||
| additionalPropertiesObj.put("context", "invalidContext{version}"); | ||
| additionalPropertiesObj.put("version", API_VERSION_1_0_0); |
There was a problem hiding this comment.
Let's move the name, context, version words to constants.
There was a problem hiding this comment.
Fixed from a31b2d2
npamudika
reviewed
Jan 30, 2024
| endpointConfig.put("production_endpoints", url); | ||
| additionalPropertiesObj.put("endpointConfig", endpointConfig); | ||
| additionalPropertiesObj.put("policies", policies); | ||
| additionalPropertiesObj.put("operations", operations); |
There was a problem hiding this comment.
Can move the property names to constants, as there are multiple usages in the class.
There was a problem hiding this comment.
Fixed from a31b2d2
npamudika
reviewed
Jan 30, 2024
| apiCreationRequestBean.setVersion(apiVersion); | ||
| apiCreationRequestBean.setDescription(apiDescription); | ||
| apiCreationRequestBean.setTags(apiTag); | ||
| apiCreationRequestBean.setTier("Gold"); |
There was a problem hiding this comment.
Shall we use APIMIntegrationConstants.API_TIER.GOLD?
There was a problem hiding this comment.
Fixed from a31b2d2
npamudika
reviewed
Jan 30, 2024
|
|
||
| HttpResponse response = restAPIPublisher.addAPIWithMalformedContext(apiCreationRequestBean); | ||
| Assert.assertNotNull(response, "Response cannot be null"); | ||
| Assert.assertEquals(response.getResponseCode(), 400, "Response Code miss matched when creating the API"); |
There was a problem hiding this comment.
Let's use Response.Status.NOT_FOUND.getStatusCode() for 400
There was a problem hiding this comment.
Fixed from a31b2d2
npamudika
reviewed
Jan 30, 2024
| apiRequest.setApiTier(APIMIntegrationConstants.API_TIER.UNLIMITED); | ||
|
|
||
| HttpResponse response = restAPIPublisher.addAPIWithMalformedContext(apiRequest); | ||
| Assert.assertEquals(response.getResponseCode(), 400, "Response Code miss matched when creating the API"); |
There was a problem hiding this comment.
Let's use Response.Status.NOT_FOUND.getStatusCode() for 400
There was a problem hiding this comment.
Fixed from a31b2d2
npamudika
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds integration tests to cover the following scenarios.