[APIM] Add Support to Config Java Access Control through JS in Script Mediator #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senthuran16
requested changes
Jan 26, 2024
...nsions/src/test/java/org/apache/synapse/mediators/bsf/javascript/JavaScriptMediatorTest.java
Outdated
Show resolved
Hide resolved
...nsions/src/test/java/org/apache/synapse/mediators/bsf/javascript/JavaScriptMediatorTest.java
Outdated
Show resolved
Hide resolved
senthuran16
approved these changes
Jan 26, 2024
|
The MI build appears to be unstable in previously merged PRs as well. However, since |
DinithHerath
reviewed
Mar 6, 2024
| * @return Whether the access is allowed or not. | ||
| */ | ||
| public static boolean isAccessAllowed(String string, AccessControlConfig accessControlConfig, | ||
| Comparator<String> comparator) { |
There was a problem hiding this comment.
Please look into the indentations in here
There was a problem hiding this comment.
Indentation seems to be ok on IntelliJ
DinithHerath
reviewed
Mar 6, 2024
| limit_java_class_access_in_scripts.class_prefixes = java.util.ArrayList | ||
| limit_java_native_object_access_in_scripts.enable = true | ||
| limit_java_native_object_access_in_scripts.list_type = BLOCK_LIST | ||
| limit_java_native_object_access_in_scripts.object_names = getClassLoader,loadClass |
There was a problem hiding this comment.
Fixed through PR #2159
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The access to java classes though JS in script mediator can be controlled through following synapse propeties