Avoid clearing buffer when ProducerError occurs in Passthru pipe #2138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves wso2/product-micro-integrator#3081
This PR resolves an OOM issue where a loop scenario is created when the backend resets the connection without properly sending the complete payload. When backend closes the connection, the
producerErrorflag of the Passthru Pipe is set to true. A previous fix[1] has been introduced to clear the buffer during such scenarios. But when the buffer is cleared, the read position of the buffer is set to 0. Hence IOUtils.copy() method tries to copy the same inputStream to outputStream again and again which leads to the OOM issue.[1] - #1933