Maintaining thread safety for class med properties #2207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since expressions such as expression="get-property('...')" or expression="$trp:..."
are dynamic and their values can change with each request, we face a potential
race condition when these expressions alter instance variables using setters.
Given that only one instance of the class mediator is created and shared among multiple
concurrent requests, this shared state can lead to inconsistent behavior and
data corruption.
To mitigate this, we need to ensure synchronization not only when the content
is altered by expression but also for each evaluation of these dynamic expressions. This ensures
that changes made by one request do not interfere with or get overwritten by
another concurrent request, maintaining thread safety and data integrity across all operations.
Fixes: wso2/product-ei#5292
SanojPunchihewa
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Since expressions such as expression="get-property('...')" or expression="$trp:..." are dynamic and their values can change with each request, we face a potential race condition when these expressions alter instance variables using setters. Given that only one instance of the class mediator is created and shared among multiple concurrent requests, this shared state can lead to inconsistent behavior and data corruption.
To mitigate this, we need to ensure synchronization not only when the content is altered by expression but also for each evaluation of these dynamic expressions. This ensures that changes made by one request do not interfere with or get overwritten by another concurrent request, maintaining thread safety and data integrity across all operations.
Fixes: wso2/product-ei#5292