Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Angular 11 updates with project structure changes #100

Merged
merged 2 commits into from
Dec 23, 2020

Conversation

zainniazi
Copy link
Contributor

There are the following changes in this PR

  • Angular 11 update.
  • Project structure as per Angular rules.
  • Fixes for issues caused on Angular 11 due to ivy.

@zainniazi
Copy link
Contributor Author

Hi @wulfsolter,
As per your suggestions, I have divided the PR is two sections.
In this PR as explained above, I have added an Angular 11 update which interlinked with the project structure change.

Project structure changes is as per https://angular.io/guide/creating-libraries

Please have a look, I appreciate your help in releasing it because it causing problem with Angular 11 projects.

Thanks

@wulfsolter
Copy link
Owner

Are you prepared to release a timely patch if this PR breaks the ~18,000 weekly downloads who rely on the project currently?

I understand it may be causing problems with Angualr11, but I also see it is serving 18,000 people every week.

@zainniazi
Copy link
Contributor Author

@wulfsolter Yes, I'm here to release the timely patches if needed.
However, I have added the test project as well where we can run tests. I'll send the test project in next PR.

@andreialecu
Copy link
Contributor

One option to prevent any breaking changes might be to merge this to a next branch and publish it as angular2-signaturepad@next on npm and get some feedback there before merging to master.

@zainniazi
Copy link
Contributor Author

Okay, @andreialecu.
I hope we release it asap in any format, this will fix angular 11 issues and the following mentioned issues
#95
#91
#78

@wulfsolter
Copy link
Owner

thanks @andreialecu

Is published on tag 'next'

┌─[wulf@WULF-THINKPAD]-[2020-11-28 10:50 - 1606513852]-[~/code/foo]
└─[$]-> npm install angular2-signaturepad@next

+ [email protected]
added 14 packages from 10 contributors and audited 14 packages in 12.15s
found 0 vulnerabilities

@zainniazi let me know if @next is working for you.

@zainniazi
Copy link
Contributor Author

zainniazi commented Nov 28, 2020

@wulfsolter I just checked and it seems like we have published the root directory.
Here are the guidelines for the new structure https://angular.io/guide/creating-libraries

These are the commands you are going to need

ng build angular2-signaturepad --prod
cd dist/angular2-signaturepad
npm publish

@wulfsolter
Copy link
Owner

thanks @zainniazi! have republished tag next

@zainniazi
Copy link
Contributor Author

zainniazi commented Nov 29, 2020

@wulfsolter Thanks for the update.
There is only one change required which is to rename Angular2SignaturepadModule to SignaturePadModule, I have updated it. Rest of it working perfectly on Angular 8-11.

As we merge this, I'll send another PR with the demo project in it.

@wulfsolter
Copy link
Owner

Thanks man, republished!

@zainniazi
Copy link
Contributor Author

Hi @wulfsolter, I just checked the latest published version and I think we might have released the wrong folder.
Instead of dist/angular2-signaturepad, it seems like its from projects/angular2-signaturepad

#100 (comment)

@wulfsolter
Copy link
Owner

wulfsolter commented Dec 1, 2020 via email

@zainniazi
Copy link
Contributor Author

@wulfsolter Thanks, works perfectly now.

@zainniazi
Copy link
Contributor Author

Hi @wulfsolter,
It seems we don't have any issues reported regarding our latest beta release.
Should we plan to release it on the normal stream?

@almothafar almothafar mentioned this pull request Dec 23, 2020
@wulfsolter wulfsolter merged commit 6083804 into wulfsolter:master Dec 23, 2020
@wulfsolter
Copy link
Owner

Thanks @zainniazi :) Published as 3.0.4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants