Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ApolloCompatibilitySkipEnumValueValidation #1521

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

flymedllva
Copy link
Contributor

@flymedllva flymedllva commented Jan 21, 2025

Motivation and Context

Need to support ApolloCompatibilitySkipEnumValueValidation opts in graphql go tools wundergraph/graphql-go-tools#1031

@StarpTech StarpTech added the internally-reviewed The issue has been reviewed internally. label Jan 28, 2025
@Aenimus
Copy link
Member

Aenimus commented Feb 4, 2025

Hi @flymedllva,

I'm afraid we still don't understand the use case. Why do you wish to use an Enum and then ignore the contract? Why not use a String at that point?

@flymedllva
Copy link
Contributor Author

flymedllva commented Feb 4, 2025

Hey

Yes, I agree that it is better to use aString, but we moved from Apollo and there the enums were passed through as strings and everything is written according to this concept, it is a big task to change, and specifically here we would be satisfied if we had the opportunity to leave the behavior to which we are accustomed

In general, if there is no support for this feature, we will either have to live on a fork with this feature or go change our old code

Copy link

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internally-reviewed The issue has been reviewed internally. router Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants