fix: deadlock when waiting on inflight events of a trigger #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StarpTech
changed the title
Aenimus
pushed a commit
that referenced
this pull request
Feb 15, 2025
🤖 I have created a release *beep* *boop* --- ## [2.0.0-rc.155](v2.0.0-rc.154...v2.0.0-rc.155) (2025-02-15) ### Bug Fixes * deadlock when waiting on inflight events of a trigger ([#1073](#1073)) ([8a2b33c](8a2b33c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where
WaitGroup.Waitcaused a deadlock with the progressing update events because waiting in the event loop starves it forever.Additionally, I removed the field
done, which caused a race with a concurrent event from the WS providers. It also wasn't useful at all.I battle-tested the change with a load test scenario where connections are reestablished multiple times a second.