-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed windows-specific problem in subprocess_repl.read_bytes() #307
base: merges
Are you sure you want to change the base?
Conversation
…at more than 1 byte is returned on every read, by converting the pipe to an asynchronous one
…il there are bytes to be read
@simonzack thanks :) Are you using Sublime Text 2 or 3? Did you test both and are all repls working as before? |
I think it should work fine after the new commits. |
Any updates on this? Thanks. |
Please solve the conflicts in repl.js, since I lack the knowledge to do so, and then we'll merge this in |
Fixed windows-specific problem in subprocess_repl.read_bytes(), so that more than 1 byte is returned on every read, by converting the pipe to an asynchronous one.
This issue comes up as a bug at some places, for example open an ipython repl prompt, then enter some non-existent variable name to generate an error. Then the color escape sequences are not stripped even when the option is set to True in SublimeREPL, as the color stripping function only has a single byte as input instead of all the output bytes.
This fixes the aforementioned problem.