Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding property styles in root document #1500

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nishu-murmu
Copy link
Contributor

Overview

Just extracted the property styles from entryCss text and append it in the root document.
Don't know if this follows standard and consistency. Please let me know.

Manual Testing

Create components within shadowDOM using createShadowRootUi API.

Related Issue

This PR closes #1461

Copy link

netlify bot commented Mar 4, 2025

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 073c29a
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/67c6ff340f0e8c000884599b
😎 Deploy Preview https://deploy-preview-1500--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Timeraa Timeraa changed the title feat: adding property styles in root document. feat: adding property styles in root document Mar 8, 2025
Copy link

pkg-pr-new bot commented Mar 8, 2025

Open in Stackblitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@1500

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@1500

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@1500

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@1500

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@1500

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@1500

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@1500

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@1500

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@1500

wxt

npm i https://pkg.pr.new/wxt@1500

commit: 073c29a

Copy link
Collaborator

@aklinker1 aklinker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might work for tailwind, where the @property declarations are last, but not for any other project that uses it.

I'd prefer a generic solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically add styles required on the root document outside shadow root
2 participants