Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow requiring built-in node modules from ESM CLI #356

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

aklinker1
Copy link
Collaborator

This closes #355

Copy link

netlify bot commented Jan 18, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 632bb34
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/65a98ec28a31140008bdc8a2
😎 Deploy Preview https://deploy-preview-356--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (54e2465) 78.59% compared to head (632bb34) 78.12%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
- Coverage   78.59%   78.12%   -0.48%     
==========================================
  Files         103      103              
  Lines        7218     7218              
  Branches      639      634       -5     
==========================================
- Hits         5673     5639      -34     
- Misses       1528     1562      +34     
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 merged commit 6f0814b into main Jan 18, 2024
16 checks passed
@aklinker1 aklinker1 deleted the analyze-fix branch January 18, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wxt build --analyze fails
1 participant