Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eglot support #25

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Eglot support #25

merged 1 commit into from
Sep 5, 2023

Conversation

wyuenho
Copy link
Owner

@wyuenho wyuenho commented Aug 30, 2023

@zyxir @egelja please delete your custom pet/eglot config in your init file and give this PR a spin, let me know if you've run into any problems.

Closes #21

@zyxir
Copy link
Contributor

zyxir commented Sep 1, 2023

I am using this branch now. No issue observed. Will report if any problem occurs.

@tusharhero
Copy link
Contributor

How long until this is merged? Also, will it support vterm shell too? (activating the virtual environment every time the vterm is launched there)

@tusharhero
Copy link
Contributor

How can I try this pr?

@wyuenho wyuenho force-pushed the eglot branch 11 times, most recently from 82e9d30 to eaf280b Compare September 5, 2023 17:59
@wyuenho wyuenho merged commit d903458 into main Sep 5, 2023
9 checks passed
@wyuenho wyuenho deleted the eglot branch September 5, 2023 18:56
@wyuenho
Copy link
Owner Author

wyuenho commented Sep 5, 2023

@tusharhero as stated many times elsewhere, and even on the issue this PR references, PET is not a virtualenv manager/wrapper/activation script etc. How you activate the virtualenv in vterm is how you activate the virtualenv in your terminal, just configure your shell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Eglot (and maybe Eshell)
3 participants