Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only include content pages in ordered collection #227

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

paulrobertlloyd
Copy link
Collaborator

With the addition of a settings.scss file, we can see that this is being included in the sub-navigation, albeit hidden because it doesn’t have a title:

<ul class="x-govuk-sub-navigation__section">
  <li class="x-govuk-sub-navigation__section-item">
    <a class="x-govuk-sub-navigation__link" href="/govuk-eleventy-plugin/assets/sass/settings.css"></a>
  </li>
  <li class="x-govuk-sub-navigation__section-item">
    <a class="x-govuk-sub-navigation__link" href="/govuk-eleventy-plugin/get-started/">Get started</a>
  </li>

This PR changes the ‘ordered’ collection that populates the side navigation items to only search for Markdown files.

@paulrobertlloyd paulrobertlloyd added this to the 6.0 milestone Dec 17, 2023
@paulrobertlloyd paulrobertlloyd merged commit 0d556aa into main Dec 18, 2023
2 checks passed
@paulrobertlloyd paulrobertlloyd deleted the fix-ordered-collection branch December 18, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants