Ensure masthead component appears within main landmark on product layout
#244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #169. Closes #170.
With a fresh set of eyes on this, as well as another (really rather strange) issue raising its head as a result of the masthead not appearing within the main container, this PR updates the product layout to overwrite the
maintemplate block:<main>contains the masthead, and keeps itsidandlangattributesbeforeContenttemplate block is removed; this is primarily used for breadcrumbs which can be added to/via the masthead componentdivwith classgovuk-main-wrapper, and which acceptsmainClassesis used to wrap the content area below the masthead component, essentially replicating the classes and nesting that is used for other layouts.Thanks to @keithkennedyHO for reporting in #169 and submitting a long neglected fix in #170, for Adam Liptrot reporting the layout issues on Windows and Android; shame on me for not addressing this issue sooner!