refactor: use absolute nunjucks import path #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "header" component macro currently imports the "site-search" macro using a relative URL. This prevents customisation of the "site-search" macro using the Nunjucks import prioritisation logic. Bringing this import inline with other import syntax across the plugin fixes this issue. For example, a consuming 11ty app wants to override the site-search macro, so can now create a "_includes/components/site-search/macro.njk" template to do that.
|
@paulrobertlloyd this is related to the recent change of nunjucks priority ordering in #354. As far as I could see, this was the only place relative URLs were used to import, but so happens to be the macro Id like to override :) |
|
Am slightly concerned that the ‘components’ import path may be too broad, but we can cross that bridge should we come to it. |
|
Fixed and released in v6.7.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "header" component macro currently imports the "site-search" macro using a relative URL. This prevents customisation of the "site-search" macro using the Nunjucks import prioritisation logic. Bringing this import inline with other import syntax across the plugin fixes this issue.
For example, a consuming 11ty app wants to override the site-search macro, so can now create a "_includes/components/site-search/macro.njk" template to do that.