Add post on improving accessibility of Rails forms #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteryates
force-pushed
the
add-finishing-touches-for-forms-post
branch
from
fc7cc3b to
185fdaf
Compare
|
|
||
| This causes a few problems. | ||
|
|
||
| The GOV.UK design system includes some complex rules around linking to fields from the error summary. For example, errors on checkbox or radio button fields should link to the first checkbox or radio button. |
There was a problem hiding this comment.
This bit isn’t explained in the post. Worth adding a separate section to explain link_errors: true?
There was a problem hiding this comment.
Yeah, this post needs three things; two seems too few!
There was a problem hiding this comment.
Header image too! 😀
|
I've got a great idea for an illustration… will rustle something up in a bit! |
peteryates
commented
Dec 22, 2024
|
|
||
| The [GOV.UK formbuilder](https://govuk-form-builder.netlify.app) makes it easy for Ruby on Rails developers to build forms that follow the rules set out in the [GOV.UK design system](https://design-system.service.gov.uk/). | ||
|
|
||
| It takes care of the markup, provides a nice API for customising the fields to meet the needs of your service and takes care of clearly dispalying any error messages. |
|
@peteryates Added an illustration – home you like it!? Also simplified the side-by-side example image, making it less busy and a smaller file size. |
paulrobertlloyd
changed the title
|
I love the graphic at the top 🤩 Thanks for the feedback, I think I've addressed it and added the third section on |
paulrobertlloyd
requested changes
Dec 23, 2024
frankieroberto
requested changes
Dec 27, 2024
paulrobertlloyd
approved these changes
Dec 27, 2024
Co-authored-by: Frankie Roberto <[email protected]>
Co-authored-by: Paul Robert Lloyd <[email protected]>
Co-authored-by: Frankie Roberto <[email protected]>
Co-authored-by: Frankie Roberto <[email protected]>
Co-authored-by: Frankie Roberto <[email protected]> Co-authored-by: Paul Robert Lloyd <[email protected]>
peteryates
force-pushed
the
add-finishing-touches-for-forms-post
branch
from
5923477 to
61c7291
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.