-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanaa #69
Sanaa #69
Conversation
Reviewer's Guide by SourceryThis PR implements a basic Bubble Sort algorithm in C++. The implementation includes three main functions: bubbleSort for the sorting logic, printArray for output formatting, and a main function that demonstrates the usage with a sample array. Class diagram for Bubble Sort implementationclassDiagram
class BubbleSort {
+void bubbleSort(int arr[], int size)
+void printArray(int arr[], int size)
}
class Main {
+int main()
}
BubbleSort <|-- Main : uses
note for BubbleSort "Contains sorting and printing functions"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sanaa-duhh - I've reviewed your changes - here's some feedback:
Overall Comments:
- Avoid using 'using namespace std' as it can lead to naming conflicts. Instead, either use explicit std:: prefixes or import specific names you need.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@@ -0,0 +1,30 @@ | |||
#include <iostream> | |||
using namespace std; | |||
void bubbleSort(int arr[], int size) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (performance): Consider adding an early exit optimization when no swaps occur in a pass
Adding a boolean flag to track if any swaps occurred in a pass would allow the function to return early when the array is already sorted, improving performance for nearly-sorted arrays.
Summary by Sourcery
New Features: