Skip to content

Latest commit

 

History

History
24 lines (21 loc) · 784 Bytes

Unnecessary event emission.md

File metadata and controls

24 lines (21 loc) · 784 Bytes

The popDebtFromQueue function of the AccountingEngine contract is emitting a useless event whenever someone tries to call it with a debtBlockTimestamp that has not been saved before.

Recommendation:

To simplify the code and prevent wastage of gas, avoid emitting unnecessary events.


Slide Screenshot

195.jpg


Slide Text

  • OpenZeppelin GEB Protocol Finding N11
  • Auditing & Logging
  • Unnecessary Event Emits
  • No Significance
  • Remove Emits
  • Save Gas

References


Tags