Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mcv feedback #5

Open
sala96wroc opened this issue Jan 12, 2025 · 0 comments
Open

Mcv feedback #5

sala96wroc opened this issue Jan 12, 2025 · 0 comments

Comments

@sala96wroc
Copy link

sala96wroc commented Jan 12, 2025

Hi guys,

Spotted a small thing that can be improved:

mcv/sec/index.ts Line 29:

You are using a hardcoded value in your if statement and you have declared an enum with this value in types.ts file. If using the enum doesn't suit your style, I'd recommend using a constant variable.

Overall the code is neatly structured and well commented making it easy to follow and understand.

Can assist with any further reviews - feel free to reach out.

X - @pats_sats
https://x.com/pats_sats?t=B-trBH3lPUKDgkIMfqUv7Q&s=09

Solana Wallet:

6zjpsFTKCy3BrGay175ePMYQ43Knespjtshh4Jqd2YMX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant