fix(climate): Preset mode always is null #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure the preset dp is the same hvac mode dp before check. - The condition would ensure that if preset and hvac share same dp to not update preset mode if hvac changed. this made because if preset contains more hvac modes that aren't supported by HA would give user ability to change it otherwise state would be stuck to the latest one and would reqiure to change it to another one then back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #486
Ensure the preset DP is the same HVAC mode DP before check.
The condition would ensure that if preset and HVAC share same DP to not update preset mode if HVAC changed. this made because if preset contains more HVAC modes that aren't supported by HA would give user ability to change it otherwise state would be stuck to the latest one and would require to change it to another one then back.