✨ [feature] Add support for Shock sensor

[pbuckley4192]

Hi,

First off, thanks for writing this App. It saved my IQPanel 2 from the scrap heap!

I noticed my setup uses "shock" sensors which werent supported by the App.

Error Seen:
2024-01-05 14:15:43.717826 WARNING qolsys_panel: sensor of unknown type: {'id': '170-7272', 'type': 'Shock', 'name': 'Upstairs Shock Detector', 'group': 'shock', 'status': 'Closed', 'state': '0', 'zone_id': 14, 'zone_physical_type': 12, 'zone_alarm_type': 0, 'zone_type': 107, 'partition_id': 0}

I've added the code needed locally and tested it against my setup. It functions as expected.

More than open to feedback!

[xaf]

Hello!

Thank you for contributing!
Could you please add the relevant test and fixtures too?

You should have the following files modified by this PR to ensure we're testing the right stuff:

• apps/qolsysgw/mqtt/updater.py
• apps/qolsysgw/qolsys/sensors.py
• tests/end-to-end/test_qolsysgw.py
• tests/integration/test_qolsys_events.py
• tests/mock_modules/testutils/fixtures_data.py

[pbuckley4192]

I'll take care of these on Monday! Thanks for the feedback!

[pbuckley4192]

All files updated.

• apps/qolsysgw/mqtt/updater.py
• apps/qolsysgw/qolsys/sensors.py
• tests/end-to-end/test_qolsysgw.py
• tests/integration/test_qolsys_events.py
• tests/mock_modules/testutils/fixtures_data.py

Note: I found a missing dependency in requirements-tools.txt. Took the chance to add it.

[xaf]

Another few comments, and there's two tests failing.
One of them related to the expected number of sensors in the tests, since this adds one :)

[pbuckley4192]

Made the required changes, thanks for the feedback

[xaf]

Still some failing tests, are you able to fix that? :)

[pbuckley4192]

Done, that failing test should work now.

[xaf]

It seems to be failing at the e2e tests now :(

It is because the group here is written with a capital S: https://github.com/XaF/qolsysgw/pull/143/files#diff-94f35fef3f4d094a51239e392ab0d740b53bfb8f3462e6ec246865437e0799c5R382
While the end-to-end tests are written with a lowercase s.

According to your message in the PR description, I believe it's supposed to be a lowercase s for shock, which means you will need to update it at the line I quoted, as well as in the unit tests! Thanks a lot for your time in contributing this :)

I'll try to apply the changes from GitHub directly and re-run the tests!

[xaf]

Ok, we're good! 🎉
Thanks for the PR!