Skip to content
This repository has been archived by the owner on Sep 25, 2024. It is now read-only.

[Mac] Tweaks for a more consistent UX #666

Merged
merged 1 commit into from
Oct 24, 2019
Merged

[Mac] Tweaks for a more consistent UX #666

merged 1 commit into from
Oct 24, 2019

Conversation

CartBlanche
Copy link
Contributor

@CartBlanche CartBlanche commented Oct 16, 2019 •
edited
Loading

Before:
Screen Shot 2019-10-24 at 20 06 48

Fixes - #667
Fixes - #625

After:
Screen Shot 2019-10-16 at 16 24 28

@CartBlanche CartBlanche self-assigned this Oct 16, 2019
@CartBlanche CartBlanche marked this pull request as ready for review October 16, 2019 15:35
@CartBlanche
Copy link
Contributor Author

PR of the Beast.

@CartBlanche CartBlanche requested review from netonjm and ermau and removed request for netonjm October 16, 2019 15:39
BretJohnson
BretJohnson previously approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@BretJohnson BretJohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the screenshots, LGTM.

netonjm
netonjm previously approved these changes Oct 24, 2019
View reviewed changes
@CartBlanche CartBlanche dismissed stale reviews from netonjm and BretJohnson via 9bba001 October 24, 2019 19:48
@BretJohnson BretJohnson self-requested a review October 24, 2019 21:09
BretJohnson
BretJohnson approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@BretJohnson BretJohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested Forms proppy with these changes. It all looks good to me.

@CartBlanche CartBlanche merged commit 8790fdf into master Oct 24, 2019
@CartBlanche CartBlanche deleted the dominique-UXTweaks branch October 24, 2019 21:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BretJohnson BretJohnson BretJohnson approved these changes

@netonjm netonjm netonjm left review comments

@ermau ermau Awaiting requested review from ermau

Assignees

@ermau ermau

@CartBlanche CartBlanche

Labels
consistency host-mac ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CartBlanche @BretJohnson @netonjm @ermau