Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo-review round 2 #485

Merged
merged 6 commits into from
Dec 5, 2023
Merged

repo-review round 2 #485

merged 6 commits into from
Dec 5, 2023

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented Dec 5, 2023

xref #468

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (2a1e4e1) 83.12% compared to head (39b7431) 83.68%.

Files Patch % Lines
cf_xarray/accessor.py 69.44% 11 Missing ⚠️
cf_xarray/units.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #485      +/-   ##
==========================================
+ Coverage   83.12%   83.68%   +0.55%     
==========================================
  Files          14       14              
  Lines        2679     2697      +18     
  Branches      189      198       +9     
==========================================
+ Hits         2227     2257      +30     
+ Misses        402      390      -12     
  Partials       50       50              
Flag Coverage Δ
mypy 44.66% <52.85%> (+1.84%) ⬆️
unittests 94.04% <76.78%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dcherian dcherian enabled auto-merge (squash) December 5, 2023 05:51
@dcherian dcherian enabled auto-merge (squash) December 5, 2023 05:52
@dcherian dcherian merged commit f573ed7 into main Dec 5, 2023
11 of 12 checks passed
@dcherian dcherian deleted the repo-review-2 branch December 5, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant