Refactor / add component schemas #7
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7 +/- ##
============================================
+ Coverage 88.04% 100.00% +11.95%
============================================
Files 2 6 +4
Lines 92 258 +166
============================================
+ Hits 81 258 +177
+ Misses 11 0 -11
Continue to review full report at Codecov.
|
|
|
||
| def __init__( | ||
| self, | ||
| data_vars: Dict[Hashable, Union[DataArraySchema, None]] = None, |
There was a problem hiding this comment.
Could any of these be abstracted/shared in .typing?
There was a problem hiding this comment.
I think so but I wasn't sure which ones I'd use more than once. I'll take another pass through the type definitions.
| Parameters | ||
| ---------- | ||
| name : str, optional | ||
| Name of the DataArray. Currently requires an exact string match. |
There was a problem hiding this comment.
Maybe temp until regex matching, but would comparing the .lower or .upper name help?
| Parameters | ||
| ---------- | ||
| name : str, optional | ||
| Name of the DataArray. Currently requires an exact string match. |
There was a problem hiding this comment.
Maybe temp until regex matching, but would comparing the .lower or .upper name help on string matching?
There was a problem hiding this comment.
Opened #9 to discuss
This PR reorganizes the xarray-schema package. A few new features are included (e.g.
to_json) but it is mostly a refactor that includes: