Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document read/write with CF encoding #67

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Document read/write with CF encoding #67

merged 2 commits into from
Jun 25, 2024

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented Jun 21, 2024 •
edited
Loading

xref #26
Needs xarray-contrib/cf-xarray#517

This doesn't handle the CRS, just the geometries.

@dcherian dcherian marked this pull request as ready for review June 25, 2024 02:55
martinfleis
martinfleis approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Especially for the work on cf-xarray side.

@martinfleis martinfleis merged commit c2260b8 into xarray-contrib:main Jun 25, 2024
9 checks passed
@dcherian dcherian deleted the add-cf-write branch June 25, 2024 11:29
@dcherian
Copy link
Contributor Author

That was mostly @jsignell and @aulemahal. I just wired the final pieces together to fit the usual Xarray patterns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinfleis martinfleis martinfleis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcherian @martinfleis