Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD][18.0] stock_dangerous_goods: Added test cases. #2

Conversation

bizzappdev
Copy link

Adding Test cases MR in OCA: OCA#1786

Copy link
Owner

@xaviedoanhduy xaviedoanhduy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quality tests, but still need some small adjustments that I wish you to improve further



class TestProductProduct(TransactionCase):
def setUp(self):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's a test class using setUp to generate test records, move it to setUpClass as it's way more performant since it runs only once.

see: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@bizzappdev bizzappdev force-pushed the 18.0-ADD-test-case-of-stock_dangerous_goods-BAD branch from a636cea to bb64af9 Compare January 27, 2025 11:40
Copy link
Owner

@xaviedoanhduy xaviedoanhduy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your efforts +
LGTM

@xaviedoanhduy xaviedoanhduy merged commit f0032d5 into xaviedoanhduy:18.0-mig-stock_dangerous_goods Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants