Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable file exclusions #159

Closed
wants to merge 2 commits into from

Conversation

anxdpanic
Copy link
Member

@anxdpanic anxdpanic commented Feb 6, 2019

To address #156 , and possibly applies to #123

Allow for environment flexibility

--exclude-file              files/folders to exclude from permissions and file extension checks
--exclude-file-ext          file extensions to exclude from permissions and file extension checks
--whitelist-file            files/folders to exclude from file extension checks
--whitelist-file-ext        file extensions to exclude from file extension checks

- allows user to exclude files/folders/file extensions from permissions and file extension checks
- allows user to exclude files/folders/file extensions from file extension checks
@razzeee
Copy link
Member

razzeee commented Feb 7, 2019

Personally I feel this is too flexible. Configs for the three (?) usecases we support should be pretty similar on each project.
And it will be a pain to setup/configure.

I would like to hear @Rechi about this.

@anxdpanic
Copy link
Member Author

I went this flexible mainly due to addon-ci vs addon local checks, where you'd want to ignore pyo/pyc and ide files/folders for local checks and not for addon-ci. Saves trying to cover all ide's and unique environments explicitly.

local:

kodi-addon-checker e:\Workspace\GitHub\plugin.video.youtube --branch=isengard --exclude-file-ext pyo pyc --exclude-file e:\Workspace\GitHub\plugin.video.youtube\.idea --whitelist-file GPL-2.0-only

ci:

kodi-addon-checker . --branch=isengard --whitelist-file GPL-2.0-only kodi-addon-checker.log

This was referenced Feb 7, 2019
@anxdpanic
Copy link
Member Author

Should I just close this and #160 instead of rebasing?

@razzeee
Copy link
Member

razzeee commented Mar 22, 2019

Yes, please do. Sorry for the confusion.

@anxdpanic anxdpanic closed this Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants