Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Decaffeinate & drop Ruby, get CI running again #584

Draft
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

max-te
Copy link

@max-te max-te commented Mar 28, 2024

I took a shot at #372, and this is the result of that. I applied decaffeinate and brought the whole build system to a working state again. From my limited testing on my local Kodi box and through the BrowserSync devmode everything seems to be working fine. This should bring us in a position where it is easier to move the project forward.

This port still needs to be followed-up by a cleanup pass over all the converted files, removing the TODO comments when done. Also, eco still uses coffeescript for the jst files.

The JS source code also still uses globals and no import/export, the coffee compile task was replaced by a simple concat. Eventually, this could be replaced by a proper bundler like esbuild / webpack.

To get the scss build working again, I replaced Ruby Sass by Dart Sass. The sass dependencies are now loaded via npm, I looked for equivalent replacements for the used packages and so far they are working out. (In hindsight it would have been easier to do this before transforming the coffeescript files)

Any thoughts on the direction this is taking?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant