Implemented about section of help page #91
Conversation
src/Pages/Help/About.elm
Outdated
|
|
||
| Status Report | ||
| --------- | ||
| **Chorus Version** 19.x-2.4.8 |
There was a problem hiding this comment.
All these shouldn't be hardcoded. Some are from chorus, some need to be fetched from kodi. Have a look at the original implementation as that should fetch these values too
There was a problem hiding this comment.
Hello @razzeee, I apologize for the delay in response. I was having my rigorous end-semester evaluations and therefore I was busy preparing for the same.
I found chorus version data was fetched from addon.xml but I didn't find any updated or good XML file decoder, so I converted the XML file to JSON and then fetched the data. I am facing 2 issues:-
- Http.get wants url. So I am pushing the file on a local server using the json-server package and then giving the absolute url in Http.get. I am trying to find a way to use the relative path in Http.get for which I have asked in Elm-Slack.
- I was not able to track down from where they are fetching KODI Version data in chorus2. If you could direct me toward the file or server.
There was a problem hiding this comment.
you can't convert the addon.xml, kodi needs it. having to maintain a second json would be fine, but inconvenient, so best would probably be a build step. at that point, you could also just build a small elm file with only the (version) constants, that should allow to sidestep the fetch problem.
There was a problem hiding this comment.
Hello @razzeee, Pls review the implementation.
Kunal-8789
force-pushed
the
implementing_about_section_help_page
branch
from
5a459df to
824ffc4
Compare
|
|
||
| [Click here for more information]: https://github.com/xbmc/chorus2/blob/master/src/lang/en/license.md | ||
| [along with this program]: https://github.com/xbmc/chorus2/blob/master/LICENSE | ||
| [developers]: http://localhost:1234/help/developers |
There was a problem hiding this comment.
We can't have links to localhost, they would need to be relative. So something like /help/developers would need to work here
|
|
||
| kodiVersion : String | ||
| kodiVersion = | ||
| "19.3" |
There was a problem hiding this comment.
We would need to feed this automatically somehow
Hi @razzeee
I have implemented About section of Help Page. Please Review.
AboutI couldn't find a way to implement the strips in the Status report section. I tried making them code blocks but it wasn't looking quite right.