[upgrade] Use FFT, various fixups, add more settings #49

kujub · 2021-05-07T19:02:31Z

Hi all!
First of all this will make it actually work like a spectrum analyzer.
Note: Changes for GL only (no directx)

Additional fixes and improvements:

cleanup code
fix swapped height-speed setting values and enable one more option to disable delaying
Render: fix wireframe mode and performance
perspective: honor display and pixel aspects to fix excessive distortion, add some settings
... (see below)

AlwinEsch

Becomed time to look. Your changes looks good and makes it better, only few parts need changed, see notes on related places.

As only part on view where seems to improved, is when no sound comes anymore, There stays one row still a bit up:

AlwinEsch · 2021-07-17T10:22:23Z

visualization.spectrum/resources/settings.xml

+            <formatlabel>30024</formatlabel>
+            <popup>false</popup>
+          </control>
+        </setting>


As this three new settings only works with GL must you add the:

<dependencies> <dependency type="visible"> <or> <condition on="property" name="IsDefined">HAS_GL</condition> <condition on="property" name="IsDefined">HAS_GLES</condition> </or> </dependency> </dependencies>

to prevent show on Windows and his DX.

As only part on view where seems to improved, is when no sound comes anymore, There stays one row still a bit up:

This was never seen here. If you paused, it is maybe normal behavior because shifting rows is paused too then.

As this three new settings only works with GL must you add the:

to prevent show on Windows and his DX.

Done

AlwinEsch · 2021-07-17T10:28:24Z

visualization.spectrum/resources/language/resource.language.en_us/strings.po

+
+msgctxt "#30024"
+msgid "%i%%"
+msgstr "%i%%"


With formal labels was something changed inside Kodi and with this style now no more supported (on Nexus) and need:

msgid "{0:d}%"

AlwinEsch · 2021-07-17T10:30:20Z

visualization.spectrum/resources/language/resource.language.en_us/strings.po

+
+msgctxt "#30022"
+msgid "%+i%%"
+msgstr "%+i%%"


What makes the + before the i, not know as this, makes it only then number if higher as 0?

Was just kinda cosmetics because actually "0%" is 100% (default) and "+10%" is 110% and so on.
Removed now as i don't know how to do this with the new format.

AlwinEsch · 2021-07-17T10:31:59Z

visualization.spectrum/resources/language/resource.language.de_de/strings.po

+
+msgctxt "#30024"
+msgid "%i%%"
+msgstr ""


As with use now the translation system by Weblate, would it better to leave de_de and the en_us unchanged.

Done (reverted)

AlwinEsch · 2021-07-17T10:44:33Z

As Note about Windows, I think also to kick the Windows DX support complete and to make via the "Angle" as GLES with it.

There then also the Question has you tested with GLES and worked correct?
And thanks a lot to look for improvements here, your help is welcome 👍

AlwinEsch · 2021-07-17T16:09:43Z

Have changed the target branch to "Nexus", after them here final can we create a backport about for Kodi Matrix.

kujub · 2021-07-18T05:21:39Z

There then also the Question has you tested with GLES and worked correct?

Tested GL only (on Fedora 33 x86-64). It seems kodi is built with support for GL and GLES, but i don't know how to switch.

Update: Rebuilt kodi 19.1 with -DAPP_RENDER_SYSTEM=gles. Then rebuilt visualization. Appears to work.

AlwinEsch · 2021-07-18T09:15:09Z

Has also tested now with GLES and works, with my reported bars seems related to the sound format on played "m4a" files, by other formats it was not present.

From my side is the request now OK and can in. Only if possible can you cleanup the commits a bit, so that the last correction commits would no longer be necessary.

With your request, it works now with his bars much more correct!

kujub · 2021-07-18T10:09:54Z

Has also tested now with GLES and works, with my reported bars seems related to the sound format on played "m4a" files, by other formats it was not present.

OK. I only played mp3 and flac.

kujub · 2021-07-21T11:03:48Z

From my side is the request now OK and can in. Only if possible can you cleanup the commits a bit, so that the last correction commits would no longer be necessary.

Squashed all fixup commits also dropping some trailing white-space.

kujub · 2021-07-22T14:38:44Z

Note: Actually newly added: SetSetting cleanup, Rotation speed setting. Perspective settings just rebased for commit cleanup.

AlwinEsch · 2021-09-04T15:24:02Z

About this request must be also checked by other Team Member's, like to use FFT, thats why for me OK. Only not complete sure about human feeling on his current displayed bars, as them mostly all complete up and slightly move then up/down to show.

Here as images:

WIth this request on 1000Hz Sinus tone
Here before on 1000Hz Sinus tone
Here with new on normal played audio:
And here how on version before:

kujub · 2021-09-04T19:28:11Z

Only not complete sure about human feeling on his current displayed bars, as them mostly all complete up and slightly move then up/down to show.

a) The bar heights are currently scaled to the full dynamic range of CDDA (96 dB ) which is almost never really used. We could add one more setting to allow smaller ranges too.

b) About sine-waves: Ideally there should be only one row of bars up, but only if one of the FFT-frequencies is exactly matched. The wave must fit exactly into the probing window used so that the beginning matches the end to really have a sine-wave detected. The only perfect frequency I found so far is 11025 Hz. (edit: 44100 Hz sample rate file) Other visualization addons seem to implement their own FFT-code, so I guess kodi's built in one isn't absolutely perfect. [edit: problem was: It did not use no window function.]

AlwinEsch · 2021-09-10T19:47:35Z

Thanks for the update will look next time.

With the bars seen, by work on another addon, a good place how I expect with FFTW. Here by ShaderToy https://www.shadertoy.com/view/4ljGD1 it shows below on "iChannel0" some bars where nice go up by related sound frequency.

Really implement spectrum analyser functionality A new setting allows one to set the dynamic range displayed to whatever is used in practice (up to 144 dB for full 24 bit audio) Note: A new class KFFTR was derived from MRFFT used in other visualizations: * discard DC bin * fix hardcoded stereo (just sum up all channels) * fix broken Hann window function (!)

Wireframe: Show all edges of bars/cuboids, but w/o confusing diagonal lines. Performance: Don't call glDrawArrays separately for each single bar. Enable face-culling.

Take account of display and pixel aspects and allow to change field size, tilt and base (bottom of bars). With zero tilt and negative base, perspective distortion can be entirely eliminated and all bars stand vertical then. With 90° tilt a funny bird's-eye view can be achieved. Additionally the size of the x*z-field can be changed. Smaller is useful for bird's-eye view and bigger for zero tilt with rotation fixed at 0° or 90° etc. Rotation speed setting is added too.

Allow up to 128 x 128 bars.

New default color mode (beside of legacy mode): Up to two bars are stacked with blue->green, green->red gradients from bottom to some constant heights. So top colors depend on relative bar heights. New monochrome color modes: Monochrome gradient from dark to bright amber/blue/green. New bar height setting 'Flat': Allow clean 2D views with changing bar top colors. Points mode: Only draw one point at top mid.

Implement smooth animation for backwards shift. Take account of fps for bar height animation speed.

Allow to start/stop/revert rotation seamlessly at any point by switching back and forth on a set of presets with normal/zero/reverse rotation settings by using hotkeys or to change any other settings parameters on the fly as long as the number of bands remains equal. A settings category called 'Presets template' allows easy setup and change of a bunch of similar presets.

kujub · 2024-01-16T13:33:36Z

Updates:

Rebased on recent Nexus (for Omega see https://github.com/kujub/visualization.spectrum/tree/pr-2)
More cleanup
New commit for FFT and perspective (API changes / add kissfft)
@AlwinEsch : With this you should really get only one bar up now with 1000 Hz sine (or other high frequencies).

Upgrades:

Add bands setting (allow up to 128 x 128 bars)
More color modes, zero bar height, single points at top mid (if points mode)
Smooth animation
Add presets and reverse rotation setting (see commit msg)
Prepare new screenshots

lrusak requested review from sarbes and AlwinEsch May 7, 2021 19:08

AlwinEsch requested changes Jul 17, 2021

View reviewed changes

AlwinEsch changed the base branch from Matrix to Nexus July 17, 2021 16:08

AlwinEsch mentioned this pull request Jul 17, 2021

Visualization.spectrum doesn't make use of pFreqData #48

Open

kujub requested a review from AlwinEsch July 18, 2021 08:21

kujub force-pushed the Matrix branch 3 times, most recently from 4f0e32b to 5084ad1 Compare July 20, 2021 21:02

kujub changed the title ~~Use FFT data, fix performance, fix wireframe mode, do some cleanup~~ Use FFT data, various fixups, add more settings Jul 22, 2021

kujub force-pushed the Matrix branch from 7347eb1 to bc1600f Compare July 22, 2021 10:30

AlwinEsch approved these changes Sep 2, 2021

View reviewed changes

kujub force-pushed the Matrix branch 2 times, most recently from 4d81f7b to 41369bb Compare September 8, 2021 17:04

kujub force-pushed the Matrix branch 6 times, most recently from 84a0c53 to b1f4f9e Compare November 26, 2023 23:05

kujub force-pushed the Matrix branch 13 times, most recently from 5a340de to fbf69a7 Compare January 11, 2024 10:07

kujub force-pushed the Matrix branch 3 times, most recently from d8d7cf3 to bca8a79 Compare January 15, 2024 18:08

kujub added 6 commits January 16, 2024 10:00

GL: Cleanup code a bit

31f894a

GL: Add no delay height speed setting

71c903c

GL: Render: Fix wireframe mode and performance

718344f

Wireframe: Show all edges of bars/cuboids, but w/o confusing diagonal lines. Performance: Don't call glDrawArrays separately for each single bar. Enable face-culling.

GL: Add Bands setting and default to 32

bdbbe6a

Allow up to 128 x 128 bars.

kujub force-pushed the Matrix branch from bca8a79 to 204d8c7 Compare January 16, 2024 09:53

kujub added 5 commits January 16, 2024 14:12

GL: Add bar width setting and fix field width

0669c61

GL: Add smooth animation and take account of fps

297fc8d

Implement smooth animation for backwards shift. Take account of fps for bar height animation speed.

Prepare new screenshots (TODO: enable after DX->GL changeover)

e24818e

kujub force-pushed the Matrix branch from 204d8c7 to e24818e Compare January 16, 2024 13:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[upgrade] Use FFT, various fixups, add more settings #49

[upgrade] Use FFT, various fixups, add more settings #49

kujub commented May 7, 2021 •

edited

Loading

AlwinEsch left a comment

AlwinEsch Jul 17, 2021

kujub Jul 17, 2021

AlwinEsch Jul 17, 2021 •

edited

Loading

kujub Jul 17, 2021

AlwinEsch Jul 17, 2021

kujub Jul 17, 2021

AlwinEsch Jul 17, 2021

kujub Jul 17, 2021

AlwinEsch commented Jul 17, 2021

AlwinEsch commented Jul 17, 2021

kujub commented Jul 18, 2021 •

edited

Loading

AlwinEsch commented Jul 18, 2021 •

edited

Loading

kujub commented Jul 18, 2021 •

edited

Loading

kujub commented Jul 21, 2021

kujub commented Jul 22, 2021

AlwinEsch commented Sep 4, 2021

kujub commented Sep 4, 2021 •

edited

Loading

AlwinEsch commented Sep 10, 2021

kujub commented Jan 16, 2024

[upgrade] Use FFT, various fixups, add more settings #49

Are you sure you want to change the base?

[upgrade] Use FFT, various fixups, add more settings #49

Conversation

kujub commented May 7, 2021 • edited Loading

AlwinEsch left a comment

Choose a reason for hiding this comment

AlwinEsch Jul 17, 2021

Choose a reason for hiding this comment

kujub Jul 17, 2021

Choose a reason for hiding this comment

AlwinEsch Jul 17, 2021 • edited Loading

Choose a reason for hiding this comment

kujub Jul 17, 2021

Choose a reason for hiding this comment

AlwinEsch Jul 17, 2021

Choose a reason for hiding this comment

kujub Jul 17, 2021

Choose a reason for hiding this comment

AlwinEsch Jul 17, 2021

Choose a reason for hiding this comment

kujub Jul 17, 2021

Choose a reason for hiding this comment

AlwinEsch commented Jul 17, 2021

AlwinEsch commented Jul 17, 2021

kujub commented Jul 18, 2021 • edited Loading

AlwinEsch commented Jul 18, 2021 • edited Loading

kujub commented Jul 18, 2021 • edited Loading

kujub commented Jul 21, 2021

kujub commented Jul 22, 2021

AlwinEsch commented Sep 4, 2021

kujub commented Sep 4, 2021 • edited Loading

AlwinEsch commented Sep 10, 2021

kujub commented Jan 16, 2024

kujub commented May 7, 2021 •

edited

Loading

AlwinEsch Jul 17, 2021 •

edited

Loading

kujub commented Jul 18, 2021 •

edited

Loading

AlwinEsch commented Jul 18, 2021 •

edited

Loading

kujub commented Jul 18, 2021 •

edited

Loading

kujub commented Sep 4, 2021 •

edited

Loading