NFT: add data-url support; add text & json nft support #317
+327
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
update: the dataurl image may have a metadata hash mismatch, so that could be the issue there [note: i haven't tested w/ reg nft's; one known issue is i have a test dataurl image that i believe is in a collection which isn't showing collection info, just name/description; haven't tracked that issue down yet, but i think this is worth moving forward with in the meantime] |
|
i've now tested with a regular off-chain image nft and it looks fine; collection info is showing etc |
|
I've found a couple of details worth tightening up for security, so please wait til I add some add'l commit(s) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gm, hope this is in a usable format etc. Happy to send a couple of NFT's over for testing if that's helpful.