Use argh instead of clap. #9
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Teddy Astie <[email protected]>
Try to make things more organized Signed-off-by: Teddy Astie <[email protected]>
Signed-off-by: Teddy Astie <[email protected]>
Signed-off-by: Teddy Astie <[email protected]>
Signed-off-by: Teddy Astie <[email protected]>
Signed-off-by: Teddy Astie <[email protected]>
Signed-off-by: Teddy Astie <[email protected]>
Signed-off-by: Teddy Astie <[email protected]>
Signed-off-by: Teddy Astie <[email protected]>
Signed-off-by: Teddy Astie <[email protected]>
Signed-off-by: Teddy Astie <[email protected]>
Signed-off-by: Tu Dinh <[email protected]>
This avoids having to install VC++ runtime along with the service. Signed-off-by: Tu Dinh <[email protected]>
Signed-off-by: Teddy Astie <[email protected]>
Signed-off-by: Tu Dinh <[email protected]>
We don't need it, and it significantly bloats up binary size and compilation time. Signed-off-by: Tu Dinh <[email protected]>
Signed-off-by: Tu Dinh <[email protected]>
* Use async syntax for GuestAgentPublisher::run() Signed-off-by: Teddy Astie <[email protected]>
Signed-off-by: Teddy Astie <[email protected]>
Signed-off-by: Teddy Astie <[email protected]>
* Use smol instead of tokio * Use flume instead of futures::mpsc Signed-off-by: Teddy Astie <[email protected]>
Signed-off-by: Teddy Astie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
argh is a bit faster to compile and smaller in executable.
Although, we need to have enum support which only works on master branch (they haven't made a release yet).