CA-390759: Backport (re-add) PBIS (PowerBroker Identity Service from #99) to release/yangtze

[bernhardkaindl]

This PR backports #99 to the branch release/yangtze to be included in the hotfix for Yangtze (if it is taken from this branch):

This PR, on top of release/yangtze is the minimal, safe regression fix of missing PBIS data for hotfixes for 8.2 CU1 https://github.com/xenserver/status-report/tree/release/yangtze

It is a backport of #99 (for master), that can be used as basis for future hotfixes.

• One example, where CA-390759: Revert removal of PBIS (PowerBroker Identity Service) for future backports. #99 and the master branch would be a valid option would be the case where we are currently planning to release the feature (it is a big change, not a small fix) of syncing RRDs to disk before capturing them.

This change is implemented as flipping the order of executing commands and of capturing files to run commands (e.g. to sync data to disk) first and then traverse the directory trees and finally capture the synced files.

This would be a very deep change, that resulted in one regression that was later discovered and when we go to work on that hotfix, it may be better to take the code that is already validated (running Python 2.7) in XS8.

In summary:

• This backport to releases/yangtze is for a fast and minimal fixup for 8.2.CU1
• whereas PR 99 for https://github.com/xenserver-next/status-report/tree/master (CA-390759: Revert removal of PBIS (PowerBroker Identity Service) for future backports. #99) is for future, big updates (like flushing RRDs before colleting them) of bugtool for Yangtze where we would probably not like to use a backport of all changes by the main branch (used in XS8 with Python 2.7) instead.

Product development is then free to use either branch as base for future releases:

One example where using https://github.com/xenserver-next/status-report/tree/master to use it as a stable base where the planned release of #51 which resulted in an issue that needs #88.

[codecov]

Codecov Report

Merging #100 (cd495e9) into release/yangtze (b93cd6e) will increase coverage by 0%.
The diff coverage is 100%.

Additional details and impacted files

@@              Coverage Diff               @@
##           release/yangtze   #100   +/-   ##
==============================================
  Coverage               85%    85%           
==============================================
  Files                   16     16           
  Lines                 2019   2024    +5     
==============================================
+ Hits                  1722   1727    +5     
  Misses                 297    297           

Files	Coverage Δ
xen-bugtool	81% <100%> (+<1%)	⬆️

Flag	Coverage Δ
python2.7-xs8-yangtze	85% <100%> (+<1%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.