Allow repos to use Sonar to manage clean code, fix warnings #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #98 +/- ##
=====================================
+ Coverage 88% 91% +2%
=====================================
Files 18 18
Lines 2196 2211 +15
=====================================
+ Hits 1939 2017 +78
+ Misses 257 194 -63
... and 1 file with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
bernhardkaindl
force-pushed
the
add-sonarcloud
branch
7 times, most recently
from
064ea92 to
c9cd952
Compare
Pull Request Test Coverage Report for Build 8420807166Details
💛 - Coveralls |
bernhardkaindl
force-pushed
the
add-sonarcloud
branch
5 times, most recently
from
1d02833 to
91437ad
Compare
- Fix warnings from SonarLint, Codacy (e.g bandit), Sourcery - Update configuration to be compatible with SonarCloud Signed-off-by: Bernhard Kaindl <[email protected]>
bernhardkaindl
force-pushed
the
add-sonarcloud
branch
7 times, most recently
from
4992e34 to
dcf9cf4
Compare
bernhardkaindl
changed the title
bernhardkaindl
changed the title
ashwin9390
previously approved these changes
Mar 25, 2024
ashwin9390
approved these changes
Mar 25, 2024
GeraldEV
approved these changes
Mar 26, 2024
| elif filetype == "tar": | ||
| tarfile.TarFile.open(filename).extractall(tmp_path) | ||
| tar = tarfile.TarFile.open(filename) |
There was a problem hiding this comment.
Worth using context managers here and line 205?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optionally allow repos to use Sonar to manage clean code and fix Sonar warnings
Quality Gate Passed Quality Gate passed
Issues
(Remark for the PR: Accepted issues are like "WONTFIX" (acknowledged, but decided to not fix)
Measures
Example PR comment by Sonarcloud:
xenserver-next#26 (comment)
xen-bugtool's code is very clean at the moment, and this PR should help to test sonarcloud.
Code coverage (also checked by sonarcloud for this PR) confirms that the changed lines in xen-bugtool and the unit tests are already covered by existing unit tests that cover 90% of the code.
I checked if the change to
disk_list()is indeed tested: Yes it is:Here is the documentation for the used GitHub action:
https://github.com/SonarSource/sonarcloud-github-action?tab=readme-ov-file