CA-404658: Split heartbeat thread #17
Conversation
BengangY
commented
Feb 14, 2025
BengangY
commented
- Split heartbeat thread
- Print thread ID at startup
|
Can you please share the test results w/ and w/o the splitting change? |
BengangY
force-pushed
the
private/bengangy/CA-404658
branch
from
addc01e to
be67a8c
Compare
| } | ||
|
|
||
| // start heartbeat sending thread | ||
| ret = pthread_create(&hb_send_thread, xhad_pthread_attr, hb_send, NULL); | ||
| if (ret) |
There was a problem hiding this comment.
Do we need to do anything here to cleanup the receiving thread if we fail to start the sending thread?
There was a problem hiding this comment.
No need. Currently, if heartbeat threads fails to create, the return status of hb_initialize is non-0, then hb_cleanup_objects is called, but it doesn't do anything (code in it will not be compiled).
BengangY
force-pushed
the
private/bengangy/CA-404658
branch
from
be67a8c to
4f0163e
Compare
I created a crontab to run "cat /proc/net/udp | grep '02B6'" on each host every 5 minute to record UDP 694 packet drop. The test results are below:
|
|
I've recently added a CI to this repo, if you rebase your branch on top of latest master then we should start to see workflow runs here. |
There was a problem hiding this comment.
I've run some testing with this change, and in a situation where xha was failing to keep up with receiving heartbeats this does seem to resolve it.
There is a separate effort underway to identify why the receiving is getting 'bogged down', as it isn't a huge load so it should cope even with sending heartbeats occasionally as well, but this change definitely appears to be an improvement so I think is worth taking regardless of the outcome of that investigation.
BengangY
force-pushed
the
private/bengangy/CA-404658
branch
from
4f0163e to
a4bf3d5
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| MTC_STATIC void * | ||
| hb_send( | ||
| void *ignore) |
Check warning
Code scanning / CodeChecker
unused parameter 'ignore' Warning
Split heartbeat thread into sending heartbeat thread and receiving heartbeat thread. Signed-off-by: Bengang Yuan <[email protected]>
BengangY
force-pushed
the
private/bengangy/CA-404658
branch
2 times, most recently
from
e165992 to
e57c590
Compare
Print all threads' ID in the xha.log at startup. Signed-off-by: Bengang Yuan <[email protected]>
BengangY
force-pushed
the
private/bengangy/CA-404658
branch
from
e57c590 to
1770cff
Compare
I have rebased on master and resolved the CI. Now it has passed all the checks. |
