Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to the gtest package #2389

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Fixes to the gtest package #2389

merged 2 commits into from
Aug 3, 2023

Conversation

deimonn
Copy link
Contributor

@deimonn deimonn commented Aug 3, 2023

I ran into a few issues when using the GTest package and decided to fix them myself as they were rather simple.

  • Fixed option main being incorrectly referenced as gtest_main, which was making the option do nothing.
  • Fixed option gmock causing the package test to fail when set to false as it'd still test GMock features.

@waruqi waruqi merged commit 0c2cbcc into xmake-io:dev Aug 3, 2023
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants