Auto-update libsigcplusplus to 3.6.0 #3078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@waruqi 不知道为啥 mac arm64 失败，看起来是没找到 libstdc++ 之类的 |
@waruqi I don’t know why mac arm64 failed. It seems that libstdc++ was not found or something like that. |
|
似乎是 linker 用了 /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang 不是 clang++，所以没有自动 link 到 c++ 库。。可以尝试 patch 下，加上 -lc++ 或者暂时禁用 arm64/shared |
waruqi
commented
Feb 29, 2024
packages/l/libsigcplusplus/xmake.lua
Outdated
| add_versions("3.4.0", "445d889079041b41b368ee3b923b7c71ae10a54da03bc746f2d0723e28ba2291") | ||
|
|
||
| add_configs("deprecated_api", {description = "Build deprecated API and include it in the library", default = false, type = "boolean"}) | ||
| if is_plat("wasm") then | ||
| add_configs("shared", {description = "Build shared library.", default = false, type = "boolean", readonly = true}) | ||
| end | ||
|
|
||
| if is_plat("macosx") then | ||
| add_syslinks("c++") |
There was a problem hiding this comment.
是包自身构建缺 link，外面加这个没用，那个是对外导出 link
|
linux/mac + meson + clang+ shared 都会出现这个问题，这应该是 meson 的锅？ |
This problem will occur in linux/mac + meson + clang+ shared. Is this the fault of meson? |
waruqi
commented
Mar 1, 2024
| import("package.tools.meson").install(package, configs) | ||
| end) | ||
|
|
||
| on_test(function (package) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version of libsigcplusplus detected (package version: 3.4.0, last github version: 3.6.0)