Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ginkgo #3382

Merged
merged 3 commits into from
Mar 6, 2024
Merged

add ginkgo #3382

merged 3 commits into from
Mar 6, 2024

Conversation

xq114
Copy link
Contributor

@xq114 xq114 commented Mar 1, 2024

  • Before adding new features and new modules, please go to issues to submit the relevant feature description first.
  • Write good commit messages and use the same coding conventions as the rest of the project.
  • Please commit code to dev branch and we will merge into master branch in feature
  • Ensure your edited codes with four spaces instead of TAB.

  • 增加新特性和新模块之前,请先到issues提交相关特性说明,经过讨论评估确认后,再进行相应的代码提交,避免做无用工作。
  • 编写友好可读的提交信息,并使用与工程代码相同的代码规范,代码请用4个空格字符代替tab缩进。
  • 请提交代码到dev分支,如果通过,我们会在特定时间合并到master分支上。
  • 为了规范化提交日志的格式,commit消息,不要用中文,请用英文描述。

@xq114
Copy link
Contributor Author

xq114 commented Mar 4, 2024

xmake-io/xmake#4657 这里没写支持android,为什么android上也在测试呢?"windows|!x86" 这种写法应该指的是windows上x86以外的架构吧

@waruqi
Copy link
Member

waruqi commented Mar 4, 2024

xmake-io/xmake#4657 这里没写支持android,为什么android上也在测试呢?"windows|!x86" 这种写法应该指的是windows上x86以外的架构吧

估计实现的有问题,先暂时别用取反好了,等下个版本修复后,再用

@waruqi
Copy link
Member

waruqi commented Mar 5, 2024

修复了 xmake-io/xmake#4793

@waruqi waruqi closed this Mar 5, 2024
@waruqi waruqi reopened this Mar 5, 2024
@waruqi waruqi merged commit fd8a58f into xmake-io:dev Mar 6, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants