Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message publishing to payer service #245

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

neekolas
Copy link
Contributor

@neekolas neekolas commented Oct 21, 2024

tl;dr

  • Actually publishes messages to nodes and blockchain from payer service
  • Changes to write ClientEnvelopes to chain instead of underlying payload types

Next up

  • Fix blockchain reading to match published message types
  • Add tests

AI Assisted summary

This PR implements the logic for publishing messages to nodes and the blockchain from the payer service. It moves the responsibility of publishing to the blockchain from the message service to the payer service. The payer service now groups incoming envelopes by their destination (node or blockchain) and handles the publishing accordingly.

The blockchain publishing interface has been updated to return transaction hashes, allowing for better tracking and verification of published messages. The code now writes entire ClientEnvelopes to the blockchain instead of just the underlying payload, providing more context and consistency in the data storage approach.

Additionally, the PR includes updates to related test files and mock interfaces to accommodate these changes, ensuring the new functionality is properly tested and integrated.

@neekolas neekolas marked this pull request as ready for review October 21, 2024 20:51
@neekolas neekolas requested a review from a team as a code owner October 21, 2024 20:51
@neekolas neekolas force-pushed the 10-18-add_node_connection_pool branch from ea704f1 to df08fca Compare October 21, 2024 22:42
@neekolas neekolas force-pushed the 10-21-add_message_publishing_to_payer_service branch from 41bc7db to f099568 Compare October 21, 2024 22:42
@neekolas neekolas force-pushed the 10-18-add_node_connection_pool branch from df08fca to 97d9ad1 Compare October 21, 2024 22:44
@neekolas neekolas force-pushed the 10-21-add_message_publishing_to_payer_service branch from f099568 to 1ac661c Compare October 21, 2024 22:44
Base automatically changed from 10-18-add_node_connection_pool to main October 21, 2024 22:48
@neekolas neekolas force-pushed the 10-21-add_message_publishing_to_payer_service branch from 1ac661c to 3d8dbd2 Compare October 21, 2024 22:48
@neekolas neekolas merged commit 1cf231c into main Oct 21, 2024
7 checks passed
Copy link
Contributor Author

Merge activity

  • Oct 21, 3:52 PM PDT: A user merged this pull request with Graphite.

@neekolas neekolas deleted the 10-21-add_message_publishing_to_payer_service branch October 21, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants